cvs commit: src/sys/dev/em if_em.c if_em.h

Gleb Smirnoff glebius at
Mon Aug 7 11:46:09 UTC 2006


On Fri, Aug 04, 2006 at 04:21:49PM +0000, Prafulla Deuskar wrote:
P> > Thanks. Any objections about merging the HEAD to RELENG_6 soon?
P> Jack Vogel is doing the merge - I will send it out to you for review.
P> So let us plan on committing early next week?

The merge is very simple:

1) take the driver from HEAD
2) rename VLAN_INPUT_TAG() macro to VLAN_INPUT_TAG_NEW()
3) revert revision 1.105, since this functionality isn't yet in RELENG_6

I have prepared the patch last week and posted it on STABLE, and several
people have already reported that they successfully run it. So, we can
commit to RELENG_6, I think.

P> Is there a report on what coverty found with if_em_hw.c?

Coverity complains that the return value of em_read_phy_reg() is
somtimes checked and sometimes is not. Can you please tell, whether
this is important report or can it be ignored?

Totus tuus, Glebius.

More information about the cvs-src mailing list