cvs commit: src/sys/dev/em if_em.c if_em.h

[Yar Tikhiy]

On Fri, Aug 04, 2006 at 09:52:31AM +0200, Stefan Farfeleder wrote:
> On Fri, Aug 04, 2006 at 11:46:57AM +0400, Yar Tikhiy wrote:
> > On Fri, Aug 04, 2006 at 09:23:23AM +0200, Stefan Farfeleder wrote:
> > > On Fri, Aug 04, 2006 at 11:19:09AM +0400, Yar Tikhiy wrote:
> > > > 
> > > > As a general remark, it is a very good idea to keep large style(9)
> > > > sweeps separate from actual code changes even if they are tiny.
> > > > Changing style(9) shouldn't alter the binary code produced, and
> > > > this can be 100% verified using cmp(1), diff(1), cksum(1), or md5(1).
> > > > Of course, changing line numbers will affect debug info, but the
> > > > latter can be strip(1)'ed.  In the case under discussion, I'd compare
> > > > if_em.o with its former version to make sure no code changed.
> > > 
> > > It will produce different code if __LINE__ is used.
> > 
> > Yeah, it's a thing to watch out for.  As are __TIME__ and __DATE__.
> > Fortunately, they are not widely used in src/, AFAIK.
> 
> Not directly, but through all kinds of assertion macros.

At least, KASSERT() doesn't use __LINE__.  No doubt there may be
others that do.

-- 
Yar