cvs commit: src/sys/net if_vlan.c

Qing Li qingli at
Wed Aug 2 03:37:19 UTC 2006

> Removing the "dead" assignment to evl->evl_encap_proto above and
> reducing the bcopy window by 2 bytes here is a nano-optimization.
> Which is worse, it smuggles hidden dot1q details in this otherwise
> encapsulation-neutral block of code.  E.g., I could use the former
> code for both dot1q and ISL privately by just redefining

   You are right.

> Grand total:  I would greately appreciate if you backed out this
> change and then fixed the tag value of -1 alone, but let me review
> that first.  Thanks!



   -- Qing

More information about the cvs-src mailing list