cvs commit: src/sys/kern subr_prf.c

Bruce Evans bde at
Mon Sep 26 04:21:13 PDT 2005

On Mon, 26 Sep 2005, Robert Watson wrote:

> rwatson     2005-09-26 08:02:24 UTC
>  FreeBSD src repository
>  Modified files:
>    sys/kern             subr_prf.c
>  Log:
>  Acquire Giant in uprintf() and tprintf() rather than asserting it.  In
>  the vast majority of cases, these functions are called without mutexes
>  held, meaning that in all but two cases, there will be no ordering
>  issues with doing this, and it will eliminate the need for changes in
>  the caller.  In two cases, mutexes are held, so Giant must be acquired
>  before those mutexes such that uprintf() and tprintf() recurse Giant
>  rather than generating a lock order reversal.
>  Suggested by:   bde



More information about the cvs-src mailing list