cvs commit: src/sys/dev/pccbb pccbb.c

M. Warner Losh imp at
Thu Sep 8 23:37:58 PDT 2005

In message: <20050909055930.GM53891 at>
            Gleb Smirnoff <glebius at> writes:
: On Thu, Sep 08, 2005 at 02:00:57PM -0600, M. Warner Losh wrote:
: M> : On Thu, Sep 08, 2005 at 05:18:42PM +0000, Warner Losh wrote:
: M> : W> imp         2005-09-08 17:18:42 UTC
: M> : W> 
: M> : W>   FreeBSD src repository
: M> : W> 
: M> : W>   Modified files:
: M> : W>     sys/dev/pccbb        pccbb.c 
: M> : W>   Log:
: M> : W>   Minor improvement for the suspend case for Ricoh based (and others)
: M> : W>   CardBus bridges.
: M> : 
: M> : Is this going to fix suspend (broken in mid-July) on APM notebooks?
: M> 
: M> Who knows?  I don't have any notebooks that suspend/resume correctly,
: M> so I can't tell you.  Sorry.  Take your chances and find out, or find
: M> someone who has the time to fix the other suspend/resume problems on
: M> my laptops.  Thanks!
: Warner, the fact is that the suspend used to work. Since two months passed
: and the regression is not fixed, I will insist on backout. I don't believe
: that the discussed commit brings a feature so important that we can stand
: suspend being broken.

I humbly disagree.  This is current, and one of the basic concepts of
current is that things break.  I've been working to get a laptop that
has an otherwise working suspend/resume to test with.  However, until
that happens, it will remain broken, and remain in current.  If we get
close to a release, then I'll think about backing it out.  I've tried
three different laptops, and all of them have other problems that are
getting in the way.

The power stuff really does help a *lot*.  I no longer have characters
eaten when I insert a card.  The sound doesn't glitch, the cards come
up much faster than before.  It is a really important feature that I
want to see widespread testing on.

I'm sorry that we disagree here.


More information about the cvs-src mailing list