cvs commit: src/sys/dev/ata atapi-cd.c

[Pawel Jakub Dawidek]

On Mon, Oct 10, 2005 at 12:12:19PM +0200, Poul-Henning Kamp wrote:
+> In message <20051010101013.GB3975 at garage.freebsd.pl>, Pawel Jakub Dawidek write
+> s:
+> >
+> >On Mon, Oct 10, 2005 at 11:06:49AM +0200, S?ren Schmidt wrote:
+> >+> On 09/10/2005, at 23:11, Peter Edwards wrote:
+> >+> 
+> >+> Why did you ask me to review this when you just committed it anyway ?
+> >+> 
+> >+> As I said I'm not sure this is the right way to fix this..
+> >
+> >It seems to be right. I do it in my GEOM classes to handle g_clone_bio()
+> >failures better. So the only objection I may have is that it could be
+> >done a bit cleaner:
+> 
+> Please see geom_disk.c

So bascially, you allocate next bio before sending current one?
That's one way of doing it, but I prefer to treat bio allocation as atomic
operation, ie. if I cannot allocate all bios, I send no bio down and call
g_io_deliver(parent_bio, ENOMEM) right away.
Do you see any protential problems with doing so?

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20051010/a2f47647/attachment.bin