cvs commit: src/sys/dev/sound/pci als4000.c via8233.c via82c686.c

[Alexander Leidinger]

netchild    2005-10-05 20:05:52 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/sound/pci    als4000.c via8233.c via82c686.c 
  Log:
  - Locking improvements.
  - Don't keep the SPDIF state in the driver private struct since it
    can be overriden by hand with pciconf(8), query it when needed instead.
  
  Regarding the locking I let Ariff explain it himself:
  ---snip---
  About the locking, that is what I'm intended to do since the beginning.
  The reason I'm not putting that along since my first patchset was
  because several people especially from amd46 camp reported that it cause
  lots of LORs, which is weird considering that I've never encounter such
  in a pretty much strict locking environment (i386). However, since our
  previous discussion with Pyun YongHyeon about strict locking, I've
  decided to bring it back for all the affected drivers, not just for
  es137x. It turns out that the root of the problem was within dsp.c
  during device open, which has been fixed since dsp.c revision 1.84.
  ---snip---
  
  Submitted by:   Ariff Abdullah <skywizard at MyBSD.org.my>
  
  Revision  Changes    Path
  1.21      +15 -0     src/sys/dev/sound/pci/als4000.c
  1.22      +24 -20    src/sys/dev/sound/pci/via8233.c
  1.37      +8 -2      src/sys/dev/sound/pci/via82c686.c