cvs commit: src/usr.sbin/portsnap/make_index make_index.c

Colin Percival cperciva at
Sun Nov 20 09:50:44 GMT 2005

Greg 'groggy' Lehey wrote:
> On Sunday, 20 November 2005 at  0:50:30 +0000, Colin Percival wrote:
>>  Log:
>>  An empty file does not have a positive number of lines.
> Yes it does.  It's 0, not -0.

As a mathematician, I must insist that 0 = -0 and is neither
positive nor negative. :-)

>>  Make sure that the number of lines read is non-zero before in
>>  order to avoid dumping core.
> This is a different (and presumably correct) test.

The correct test is actually to verify that the number of lines
is positive, but while we cannot assume this (as I originally
did), we can assume that the number of lines is non-negative
(and all non-negative non-zero values are positive).

Colin Percival

More information about the cvs-src mailing list