cvs commit: src/sys/net if.c if_arcsubr.c if_arp.h if_bridge.c if_ef.c if_ethersubr.c if_fddisubr.c if_fwsubr.c if_iso88

[Ruslan Ermilov]

Hi Bill,

On Sun, Nov 13, 2005 at 09:23:45PM +0000, Bill Paul wrote:
> [...]
> 
> >     sys/compat/ndis      subr_ndis.c 
> 
> [...]
> 
> >   - Store pointer to the link-level address right in "struct ifnet"
> >     rather than in ifindex_table[]; all (except one) accesses are
> >     through ifp anyway.  IF_LLADDR() works faster, and all (except
> >     one) ifaddr_byindex() users were converted to use ifp->if_addr.
> >   
> >   - Stop storing a (pointer to) Ethernet address in "struct arpcom",
> >     and drop the IFP2ENADDR() macro; all users have been converted
> >     to use IF_LLADDR() instead.
> 
> For the umpity umpth time: I'm trying to keep it so that the same
> NDIS code will compile on 7.x, 6.x and 5.x. Having one set of code
> means I don't need to go nuts doing merges from one branch to the
> next: I can just pull the files over and be done with it.
> 
Understood.

> You did
> not consider this when modifying subr_ndis.c, and now you have broken
> it for the 6.x and 5.x branches.
> 
Yes I did.

> More importantly, you broke it in
> a very subtle way that only shows up as a kernel panic a runtime.
> 
Can you please give me more details about this panic?


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20051114/4bc30efa/attachment.bin