cvs commit: src/sys/dev/bge if_bge.c
nate at root.org
Thu Nov 10 18:40:31 GMT 2005
Pawel Jakub Dawidek wrote:
> On Wed, Sep 28, 2005 at 09:38:33PM +0200, Pawel Jakub Dawidek wrote:
> +> On Wed, Sep 28, 2005 at 12:31:14PM -0700, Nate Lawson wrote:
> +> +> Pawel Jakub Dawidek wrote:
> +> +> >pjd 2005-09-28 19:20:49 UTC
> +> +> > FreeBSD src repository
> +> +> > Modified files:
> +> +> > sys/dev/bge if_bge.c Log:
> +> +> > Implement suspend/resume methods to be more ACPI friendly.
> +> +> > I'm able to suspend/resume my laptop without this change, but then I need
> +> +> > to wait for the watchdog to reset the card.
> +> +> > With this change, it is ready immediately.
> +> +> > Glanced at by: glebius
> +> +> > Revision Changes Path
> +> +> > 1.96 +36 -0 src/sys/dev/bge/if_bge.c
> +> +>
> +> +> Great, thanks! To other developers with hardware that doesn't work for suspend/resume, this is the area that needs the most improvement. There are known cases of at least
> +> +> agp and apic breaking resume.
> +> On my ThinkPad t43 suspend/resume works just fine in most cases, but
> +> sometimes (once every ~20 suspends) it stops before turning off LCD -
> +> the moon-led is turned on, but LCD is on as well and system freeze
> +> hard.
> +> What kind of debug can I add to track down the problem?
> +> Can we printf some steps done on suspend (which device's suspend method
> +> is called, etc.)?
> Just want to note, that this commit fixed my hangs totally. I haven't
> seen them since then.
Great, thanks for your work. I'm not sure anyone else pays attention,
but I'll say it again -- most suspend/resume problems are
hardware-specific and need to be fixed in their associated drivers. If
you have hardware that doesn't work, you're the perfect candidate to fix
More information about the cvs-src