cvs commit: src/lib/libstand Makefile

[Ruslan Ermilov]

On Mon, May 30, 2005 at 02:14:02PM +0300, Maxim Sobolev wrote:
> Ruslan Ermilov wrote:
> >Hi,
> >
> >On Sun, May 29, 2005 at 09:05:58PM +0000, Maxim Sobolev wrote:
> >
> >>sobomax     2005-05-29 21:05:58 UTC
> >>
> >> FreeBSD src repository
> >>
> >> Modified files:
> >>   lib/libstand         Makefile 
> >> Log:
> >> Add missed ${.CURDIR}/../../contrib/bzip2 into include search path, 
> >> otherwise
> >> old version of bzlib.h can be picked up from the /usr/include.
> >> 
> >> Revision  Changes    Path
> >> 1.51      +1 -1      src/lib/libstand/Makefile
> >>
> >
> >Changes like this, while harmless, unnecessarily pollute makefiles.
> >During buildworld we first install new headers then build new
> >libraries then the rest.  When doing standalone compiles, the same
> >procedure should generally be followed.  (Otherwise, you'd end up
> >changing every utility's makefile that uses libstand to add this
> >-I to CFLAGS.)
> 
> This is incorrect assertion since libstand hides implementation details, 
> so that it is not necessary to include bzlib.h into code which uses 
> libstand.
> 
But if you were to standalone test the build of loader(8) with an
updated libstand library, you'd have to (as an alternative to a full
"make buildworld"):

1.  build/install updated headers
2.  build/install updated libstand
3.  build loader

My point was to let you know that what you did was not necessary for
a normal "make buildworld" case (contrary to the commit log), and is
only useful in standalone compile, and its usefullness is only
limited to building the library itself, not its consumers.

I don't ask you to take any actions, but if you feel like refining
a commit log this would be appreciated.  :-)


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20050530/4deac342/attachment.bin