cvs commit: src/contrib/top commands.c machine.h top.c src/usr.bin/top machine.c

Brian Fundakowski Feldman green at FreeBSD.org
Mon May 23 16:04:25 GMT 2005


On Mon, May 23, 2005 at 12:33:44AM -0700, David O'Brien wrote:
> On Wed, May 18, 2005 at 01:30:08PM +0000, Giorgos Keramidas wrote:
> > keramida    2005-05-18 13:30:08 UTC
> > 
> >   FreeBSD src repository (doc committer)
> > 
> >   Modified files:
> >     contrib/top          commands.c machine.h top.c 
> >     usr.bin/top          machine.c 
> >   Log:
> >   Merge the CPU and WCPU columns in a single %6.2f column, add a new 'C'
> >   command that toggles between the two and update the ORDER_PCTCPU()
> >   macro to sort correctly by the visible "cpu" value.
> 
> Having both CPU and WCPU are a lot more useful than showing the number of
> threads.  Out of the top 70 processes I'm running right now, only _1_ is
> multi-threaded.
> 
> How about backing all this out and making your toggle be between #threads
> and something else -- with the something else being the default thing
> shown.
> 
> I still don't know what was wrong with the 'H' display of top(1) which
> was all about threading.

Could you explain what WCPU/CPU are supposed to differentiate?  In years
of using FreeBSD I don't think I've seen them ever be different, so I'm
always left wondering why there's what appears to be wasted screen
real-estate.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\


More information about the cvs-src mailing list