cvs commit: src/sys/dev/ipw if_ipw.c

[Peter Jeremy]

On Sun, 2005-May-22 21:05:48 +0200, Damien Bergamini wrote:
>>Why?  A good freebsd commit msg explains why you make a change.
>
>Basically because the Linux driver does it and because some users
>reported that this fixes issues with ACPI.  Remember that I have
>zero documentation for this chipset except the Linux driver itself
>which is very poorly commented.  And Intel refuses to answer to
>any technical question regarding the hardware.

Can I suggest that this is close to the sort of information that
should be included in this sort of commit message.  As an example:
  A number of people have reported [describe type of problem]
  with suspend/resume using this chipset.  Technical documentation
  is not available but Linux uses this fix/work-around and it seems
  to also fix/hide the problem on FreeBSD.

There should probably be something similar as a comment in the code.

IMHO, this is worth a further commit (either including some comments
in the code or as a forced commit).  Otherwise the next person to look
at the driver will wonder what's going on.
-- 
Peter Jeremy