cvs commit: src/sys/compat/linux linux_ioctl.c

[Brooks Davis]

On Thu, Mar 24, 2005 at 03:55:59PM -0500, John Baldwin wrote:
> On Thursday 24 March 2005 03:19 pm, Brooks Davis wrote:
> > On Thu, Mar 24, 2005 at 09:09:43PM +0100, Stefan Farfeleder wrote:
> > > On Thu, Mar 24, 2005 at 12:02:10PM -0800, Brooks Davis wrote:
> > > > Prior to C99, I think #error wasn't specified.  C99 does specify it.
> > >
> > > C89/90 had #error too.
> >
> > I stand corrected.  Now that I think about it, all but the perverse
> > preprocessors would implement #error just by blowing up on an unknown
> > directive so even that isn't an issue.  In any case, I've made the
> > change and the new code is at least shorter.  It's really only there for
> > people mucking with kernel internals who should be able to figure out
> > what it means.
> 
> We could always just change CTASSERT() to use #error if that is better.

#error would be better if we could change the CTASSERT prototype to
output a useful error message.  I suppose we could add a new macro that
took an argument and implement CTASSERT in terms of it.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20050324/6bb52b4e/attachment.bin