cvs commit: src/lib/libarchive Makefile archive.h.in archive_read_support_format_iso9660.c

Scott Long scottl at freebsd.org
Sun Jan 2 19:45:47 GMT 2005


Andrea Campi wrote:
> Hi,
> 
> On Sun, Jan 02, 2005 at 05:21:15AM +0000, Tim Kientzle wrote:
> 
>>  First cut support for extracting from ISO9660 disk images.
>>  This seems to be able to extract a TOC and extract files from
>>  the couple of ISO images I've tested it with.
>>  
>>  Treat this as experimental proof-of-concept code for the
>>  moment.  There are still a bunch of debug messages (there
>>  are a few oddities in ISO9660 that I haven't yet figured
>>  out how to handle), a lot of bugs to be addressed (this
>>  code leaks memory very badly), and a lot of missing features (no
>>  Rockridge support, in particular).  I'd appreciate
>>  feedback from anyone who understands ISO9660 format
>>  better than I do. ;-)
> 
> 
> I do appreciate your work on libarchive and bsdtar, and I'm very pleased
> we have a totally BSD clean tar.
> 
> However, it's always been my understanding that doing development
> in the main repository was frowned upon. After all, that's the reason
> why there's a projects sub-repository. I fail to see the reason for
> committing this, or portability-only changes as you committed in the
> past, as a work-in-progress when you could have kept it somewhere else
> until such time as you were totally ready.
> 
> Again: I like you work and I like this particular change, I'm mentioning
> it now because I've thought about this again and again in several
> instances.
> 
> Bye,
> 	Andrea
> 

The various sub-repositories are tools.  They exist and are provided to 
aid developers doing work, and while their use is greatly encouraged, it
is not strictly required.  CVS HEAD is still a developement branch, and
as long as work going in there compiles and doesn't needlessly conflict
or interfere with other parts of the tree, WIP commits like this are OK.

Scott


More information about the cvs-src mailing list