cvs commit: src Makefile.inc1 src/share/mk bsd.compat.mk

[David O'Brien]

On Mon, Feb 28, 2005 at 11:36:22AM +0200, Ruslan Ermilov wrote:
> On Mon, Feb 28, 2005 at 11:34:14AM +0200, Ruslan Ermilov wrote:
> > On Mon, Feb 28, 2005 at 09:23:38AM +0000, David E. O'Brien wrote:
> > > obrien      2005-02-28 09:23:38 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     .                    Makefile.inc1 
> > >     share/mk             bsd.compat.mk 
> > >   Log:
> > >   Accept the old user interface for NO_CLEAN as it is a POLA violation as
> > >   we've eventually changed the user interface of a common command.
> > >   
> > >   Revision  Changes    Path
> > >   1.486     +3 -0      src/Makefile.inc1
> > >   1.19      +0 -1      src/share/mk/bsd.compat.mk
> > > 
> > Why did you do this?  bsd.compat.mk already handled this, and
> > Makefile.inc1 is always called with ``-m /usr/src/share/mk''.
> > Even if you call Makefile.inc1 directly, and your /usr/share/mk
> > is up-to-date, you'll get a warning and setting.  Would you
> > please revert this change?
> > 
> Or maybe I misunderstood you, and you just wanted it to be quiet?
> Even so, please handle it all in bsd.compat.mk.

Looking at bsd.compat.mk, especially with "BURN_BRIDGES" in there; I'd
like to ask you for a patch you'd be happy with that isn't going away in
a few months when the bridges burn.  A correct patch will have to add
another layer of .if statements in the case of "NOCLEAN".
 
-- 
-- David  (obrien at FreeBSD.org)