cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c

Nate Lawson nate at
Sat Dec 17 10:29:06 PST 2005

Scott Long wrote:
> Nate Lawson wrote:
>>njl         2005-12-17 03:57:10 UTC
>>  FreeBSD src repository
>>  Modified files:
>>    sys/sys              ktr.h 
>>    sys/kern             kern_clock.c kern_switch.c 
>>  Log:
>>  Clean up unused or poorly utilized KTR values.  Remove KTR_FS, KTR_KGDB,
>>  and KTR_IO as they were never used.  Remove KTR_CLK since it was only
>>  used for hardclock firing and use KTR_INTR there instead.  Remove
>>  KTR_CRITICAL since it was only used for crit enter/exit and use
>>  KTR_CONTENTION instead.
>>  Revision  Changes    Path
>>  1.183     +1 -1      src/sys/kern/kern_clock.c
>>  1.118     +2 -2      src/sys/kern/kern_switch.c
>>  1.35      +12 -12    src/sys/sys/ktr.h
> Um, I was using KTR_CRITICAL for schedgraph.  It was actually quite
> useful.  Compressing the option space only makes the options less
> useful.  Surely there has to be a better solution.  Or, at least you
> could call for comments before you alter this stuff.

You didn't speak up about that in the previous discussion on arch@, 
starting 10/31/2005.  The only comment was jhb@ saying it was not useful 
alone, and he's the only one doing work on critical sections lately.

If you can think of another use for this besides one event (enter/exit), 
feel free to add it back.  Or, consider adding KTR_SUBSYS as a one-off 
use like KTR_DEV is for other parts of the system.  KTR_CRITICAL would 
be conditionally defined as KTR_SUBSYS when needed.


More information about the cvs-src mailing list