cvs commit: src/sys/net if_bridge.c

Giorgos Keramidas keramida at
Sat Aug 27 21:07:58 GMT 2005

On 2005-08-12 10:54, Andrew Thompson <thompsa at> wrote:
>>>> Use m_copypacket() which is an optimization of the common case
>>>> m_copym(m, 0, M_COPYALL, how).
>>>> This is required for strict alignment architectures where we align the
>>>> IP header in the input path but m_copym() will create an unaligned copy
>>>> in bridge_broadcast(). m_copypacket() preserves alignment of the first
>>>> mbuf.
>> I guess we should document this difference between m_copym and m_copypacket ?!
> It is in the comment block which is how I discovered it, but mbuf(9) is missing
> the info about alignment.
> uipc_mbuf.c:
>  /*
>   * Copy an entire packet, including header (which must be present). [...]

We should probably document it in the manpage too though.  How about
adding the same sentence to the ``Note:'' of m_copypacket() in mbuf.9?

More information about the cvs-src mailing list