cvs commit: src/sys/ufs/ffs ffs_vfsops.c

Bruce Evans bde at
Tue Aug 23 07:40:05 GMT 2005

On Mon, 22 Aug 2005, Suleiman Souhlal wrote:

> On Aug 22, 2005, at 5:55 AM, Scott Long wrote:
>> Suleiman Souhlal wrote:
>>> ssouhlal    2005-08-21 22:06:41 UTC
>>>   FreeBSD src repository
>>>   Modified files:
>>>     sys/ufs/ffs          ffs_vfsops.c   Log:
>>>   Set the mountpoint path in the superblock (fs_fsmnt) at mount-time
>>>   so that it appears in the various messages (not cleanly unmounted,
>>>   filesystem full, etc). This has been broken since rev 1.261.
>>>     Revision  Changes    Path
>>>   1.292     +2 -1      src/sys/ufs/ffs/ffs_vfsops.c
>> What was wrong with vfs_mountedfrom()?
> The string it expects is the path to a device, and not to a mountpoint.
> We already call it in ffs_mount() with the right path.

The main difference is actually that vfs_mountedfrom() copies from ffs
to vfs, but copying from vfs to ffs is wanted.  The direction of the
copy is verbosely documented in a comment immediately before the code:

 	 * Set FS local "last mounted on" information (NULL pad)
 	       ^^^^^^^^       ^^^^^^^^^^

The largest of the style bugs in rev.1.261 was that it left this comment
not even echoing the code.


More information about the cvs-src mailing list