cvs commit: src/sys/geom/label g_label.c

Gavin Atkinson gavin.atkinson at
Tue Aug 16 09:01:54 GMT 2005

On Tue, 2005-08-16 at 10:16 +0200, Pawel Jakub Dawidek wrote:
> On Mon, Aug 15, 2005 at 08:58:14AM -0400, Brian Fundakowski Feldman wrote:
> +> > +> Why would we want to prevent the usage of a specific directory structure
> +> > +> to represent GEOM's namespace, if that's what the administrator wants?
> +> > 
> +> > If the label name is 'foo/bar' it doesn't seems right to create 'foo'
> +> > directory and provider 'bar' inside. The label could be also '../random'
> +> > or something like this and I want to save administrator/user nasty surprises
> +> > when he inserts some random CD.
> +> 
> +> I like the idea of rejecting the latter, but what is the harm of the first
> +> case?  If I call something "foo/bar", I'll be surprised to find out that
> +> it's located at /dev/foo_bar... my preference would be for the name to be
> +> rejected completely instead of remapped, if a '/' is to not be allowed,
> +> but that's my own.
> 	# cd /dev/foo
> 	# rm/anything bar
> There was no label 'bar', right. Anyway. Instead of rejecting labels with
> '/' I can print a warning on the console that a bit different label will be
> used. What do you say?

FWIW, I would prefer to see this backed out, or at least not MFC'd.  I'm
using labels containing slashes as a way to split a large number of
devices up in /dev, and MFCing this would presumably break my setup.  As
far as I can tell, if somebody has used a "/" in a label, then that was
an administrative decision, and if possible we should obey that.

Is there any technical reason why a "/" cannot be allowed?  I do agree
that filtering out any occurances of "../" is a good idea.


More information about the cvs-src mailing list