cvs commit: src/sys/geom/label g_label.c

[Brian Fundakowski Feldman]

On Mon, Aug 15, 2005 at 09:00:33AM +0200, Pawel Jakub Dawidek wrote:
> On Mon, Aug 15, 2005 at 01:37:57AM -0400, Brian Fundakowski Feldman wrote:
> +> On Fri, Aug 12, 2005 at 12:05:09AM +0000, Pawel Jakub Dawidek wrote:
> +> > pjd         2005-08-12 00:05:09 UTC
> +> > 
> +> >   FreeBSD src repository
> +> > 
> +> >   Modified files:
> +> >     sys/geom/label       g_label.c 
> +> >   Log:
> +> >   Avoid creating directories in devfs by changing all '/' in labels to '_'.
> +> >   
> +> >   Idea from:      Stanislav Sedov <stas at 310.ru>
> +> >   MFC after:      3 days
> +> 
> +> Why would we want to prevent the usage of a specific directory structure
> +> to represent GEOM's namespace, if that's what the administrator wants?
> 
> If the label name is 'foo/bar' it doesn't seems right to create 'foo'
> directory and provider 'bar' inside. The label could be also '../random'
> or something like this and I want to save administrator/user nasty surprises
> when he inserts some random CD.

I like the idea of rejecting the latter, but what is the harm of the first
case?  If I call something "foo/bar", I'll be surprised to find out that
it's located at /dev/foo_bar... my preference would be for the name to be
rejected completely instead of remapped, if a '/' is to not be allowed,
but that's my own.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\