cvs commit: src/lib/libc/regex regex2.h

Andrey Chernov ache at FreeBSD.ORG
Sat Aug 13 12:01:55 GMT 2005

On Sat, Aug 13, 2005 at 02:30:16AM +0000, Tim J. Robbins wrote:
> tjr         2005-08-13 02:30:16 UTC
>   FreeBSD src repository
>   Modified files:
>     lib/libc/regex       regex2.h 
>   Log:
>   Change OUT from -2 to CHAR_MIN-1, making it impossible for it to
>   inadvertently match a negative char in the RE being compiled.

It seems this commit may mask the bug where signed comparison used.
Better fix perhaps to make compared char unsigned in all places, i.e.
	if (-2 == (unsigned char)'\254')


More information about the cvs-src mailing list