cvs commit: src/usr.sbin/config main.c

M. Warner Losh imp at bsdimp.com
Fri Apr 22 18:25:30 PDT 2005


In message: <94969eabff134918730e7dcead17bb51 at xcllnt.net>
            Marcel Moolenaar <marcel at xcllnt.net> writes:
: On Apr 22, 2005, at 1:34 PM, Ruslan Ermilov wrote:
: 
: >>> I personally fail to see how this can be solved...  :-(
: >>
: >> Ok, what about this:
: >> mkdep(1) creates lines of the form
: >>
: >> 	foo.o: foo.c inc1.h inc2.h
: >>
: >> Would this problem be solved if mkdep(1) created lines like:
: >>
: >> 	foo.o .depend: foo.c inc1.h inc2.h
: >>
: >> or equivalent?
: >>
: >> Would something else break if we do that?
: >>
: > I fail to see what this gives us, except for also breaking
: > "make .depend" when .depend is present and inc2.h disappears.
: 
: True, there is a phase ordering problem. But isn't that something
: that can be worked around by making the necessary adjustments to
: make(1). The adjustments would be that if .depend is out of
: date, it is being made without making any sources that are out
: of date (or missing). This may require adding a special source
: to the mix of special sources that make(1) already has: .SOFTDEP
: or something like that. One can also hardcode this special case,
: but that seems ugly.

Looks like Justin's changes just make the problem worse.  It make the
make depend fail, where before it would just fail to generate a new
.depend file.

The only thing that has a chance of working would be something like:

ALLDEPENDS=<generated by mkdep and is the union of all the files on
		      the right hand side of the :>
beforebeforedepend:
.for __i in ${ALLDEPENDS}
.if !exists($__i)
    F := $F $__i
.endif
.endfor
.if !empty($F)
    rm -f .depend
.endif

and then add beforebeforedepend before beforedepend and adjust the
ordering rules accordingly.

Make could be modified to have exists take a list of files and return
true iff they all exist...

Warner


More information about the cvs-src mailing list