cvs commit: src/sys/dev/ata ata-all.c ata-all.h ata-dma.c ata-pci.c

[Yar Tikhiy]

On Wed, Apr 20, 2005 at 11:51:32PM +0000, Doug Ambrisko wrote:
> ambrisko    2005-04-20 23:51:32 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:        (Branch: RELENG_4)
>     sys/dev/ata          ata-all.c ata-all.h ata-dma.c ata-pci.c 
>   Log:
>   Add in Promise and Intel SATA support based on FreeBSD 5.X ATAng.
>   This gets the HW to work but not to deal with SATA errors.  So if
>   the drive has a read error it will probably lock up.  This is
>   a small subset of my patches that do deal with these errors and
>   other issues in FreeBSD and ata-raid.
>   
>   Sponsored by:   IronPort Systems
>   
>   Revision   Changes    Path
>   1.50.2.49  +168 -36   src/sys/dev/ata/ata-all.c
>   1.26.2.15  +166 -13   src/sys/dev/ata/ata-all.h
>   1.35.2.39  +95 -17    src/sys/dev/ata/ata-dma.c
>   1.32.2.22  +164 -18   src/sys/dev/ata/ata-pci.c

I myself was bitten by RELENG_4 ATA support lagging behind modern
hardware, which made me move to RELENG_5 on some systems at last.
However, isn't your change too big and possibly destabilizing for
the conservative RELENG_4 branch?  I'm judging by the number of
changed lines only.  And honestly, I'm having trouble understanding
from the commit message whether your change introduces or corrects
the bug in SATA error detection.

Would you mind commenting on these two issues?  Thanks a lot!

-- 
Yar