cvs commit: src/lib/libc/net getproto.c getprotoent.c getprotoname.c netdb_private.h

[Daniel Eischen]

On Tue, 19 Apr 2005, Daniel Eischen wrote:

> On Wed, 20 Apr 2005, Hajimu UMEMOTO wrote:
>
> > Hi,
> >
> > deischen> Stop polluting the namespace.  If the externally visible functions
> > deischen> you add are not in a standard and are only for use within libc,
> > deischen> they need to be prefixed with "_" or "__".  I haven't paid attention
> > deischen> to your other commits in libc, but please go back and fix other
> > deischen> occurrences if there are any.  Or make them static if they can
> > deischen> be.
> >
> > The functions I added are prefixed with `__'.
>
> Look at src/lib/libc/net/getprotoent.c (the only file I examined).
> You added getprotoent_r, setprotoent_r, and endprotoent_r.  Even
> your commit message says this ;-)  These functions are not in the
> POSIX spec as far as I can see.

Nevermind.  I just saw the #defines in netdb_private.h.  Is there
a reason why these are all #defined instead of just being declared
as __foo()?

-- 
Dan Eischen