cvs commit: src/sys/kern kern_fork.c

Brian Fundakowski Feldman green at
Thu Sep 30 23:08:33 PDT 2004

On Fri, Oct 01, 2004 at 05:01:29AM +0000, David Schultz wrote:
> das         2004-10-01 05:01:29 UTC
>   FreeBSD src repository
>   Modified files:
>     sys/kern             kern_fork.c 
>   Log:
>   Avoid calling _PHOLD(p1) with p2's lock held, since _PHOLD()
>   may block to swap in p1.  Instead, call _PHOLD earlier, at a
>   point where the only lock held happens to be p1's.

Since you seem to have a handle on this: how hard do you think it
would be to make all the [_]PHOLD() consumers able to handle an
error return?

Good job finding all these bugs!

Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\

More information about the cvs-src mailing list