cvs commit: src/sys/net if.c

[Brian Fundakowski Feldman]

On Wed, Sep 22, 2004 at 08:01:05AM -0700, Brooks Davis wrote:
> On Wed, Sep 22, 2004 at 09:00:52AM -0400, Brian Fundakowski Feldman wrote:
> > On Wed, Sep 22, 2004 at 08:59:42AM +0000, Brooks Davis wrote:
> > > brooks      2004-09-22 08:59:42 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/net              if.c 
> > >   Log:
> > >   Fix a LOR where ifconf() used copyout while holding a mutex.  This LOR
> > >   was seen when configuring addresses on interfaces using ifconfig.  This
> > >   patch has been verified to work with over eight thousand addresses
> > >   assigned to an interface.
> > >   
> > >   LOR id:         031
> > 
> > You really need to be running with INVARIANTS if you plan on committing
> > kernel code, or people are likely to get angry when their systems crash
> > for stupid reasons.
> 
> Sorry about that.  Pass the pointy had please. :-(

No hard feelings, since I'm used to having a new issue or two every kernel
upgrade, but this really should be a lesson to anyone listening that kernel
development without INVARIANTS (and sometimes WITNESS) is a big no-no.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\