cvs commit: src/lib/libc/i386/net htonl.S ntohl.S

[Ruslan Ermilov]

On Mon, Oct 18, 2004 at 05:19:36PM +0000, David E. O'Brien wrote:
> obrien      2004-10-18 17:19:36 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     lib/libc/i386/net    htonl.S ntohl.S 
>   Log:
>   Sync with sys/i386/include/endian.h: use the single instruction 'bswap'.
>   
>   Revision  Changes    Path
>   1.10      +4 -0      src/lib/libc/i386/net/htonl.S
>   1.10      +4 -0      src/lib/libc/i386/net/ntohl.S
 
:  ENTRY(__htonl)
:         movl    4(%esp),%eax
: +#ifdef I386_CPU
:         xchgb   %al,%ah
:         roll    $16,%eax
:         xchgb   %al,%ah
: +#else
: +       bswap   %eax
: +#endif
:         ret

Ahem, but this makes this code unsuitable for i386.  I386_CPU
is only defined if kernel config file has "cpu I386_CPU", and
this has little relation to libc if at all.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041018/f7ab0663/attachment.bin