cvs commit: src/sys/sys mbuf.h src/sys/kern uipc_mbuf2.c src/share/man/man9 mbuf_tags.9

Sam Leffler sam at errno.com
Sat Oct 9 08:15:20 PDT 2004


Gleb Smirnoff wrote:
> glebius     2004-10-09 13:25:19 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/sys              mbuf.h 
>     sys/kern             uipc_mbuf2.c 
>     share/man/man9       mbuf_tags.9 
>   Log:
>   Remove inlined m_tag_free(). Rename _m_tag_free() to m_tag_free()
>   and make it visible (same way as in OpenBSD). Describe usage in manpage.
>   
>   This change is useful for creating custom free methods, which
>   call default free method at their end.
>   
>   While here, make malloc declaration for mbuf tags more informative.
>   

I don't recall your showing me the change to remove m_tag_free in 
mbuf.h.  These change the semantics of calling m_tag_free--before they 
called the method pointer, but now they explicitly call the static 
function which is typically not what is desired.  Your original request 
was solely to expose the _m_tag_free function so that code could access 
it; but you've done far more than that with this commit.  I believe you 
should revert the API change.

	Sam



More information about the cvs-src mailing list