cvs commit: src/sys/sys pbioio.h src/sys/i386/isa pbio.csrc/sys/conf files.i386 src/sys/i386/conf NOTES

[Nate Lawson]

Scott Long wrote:
> Nate Lawson wrote:
>> Marcel Moolenaar wrote:
>>> On Thu, Oct 07, 2004 at 04:21:03PM +0000, Warner Losh wrote:
>>>
>>>> imp         2004-10-07 16:21:03 UTC
>>>>
>>>>  FreeBSD src repository
>>>>
>>>>  Modified files:
>>>>    sys/conf             files.i386    sys/i386/conf        NOTES 
>>>>  Added files:
>>>>    sys/sys              pbioio.h    sys/i386/isa         pbio.c  Log:
>>>>  Port pbio to HEAD.
>>>
>>> I appreciate your speed, but don't you think that pbioio.h is pretty
>>> MD given that the driver only exists on i386. Wouldn't 
>>> <machine/pbioio.h>
>>> be a better place?
>>
>> Also, I think our policy for both RELENG_4 and -current is new 
>> inb/outb in new drivers.  The bus_space stuff is pretty easy to use so 
>> this isn't too bad a requirement.
> 
> I agree that new code should _not_ be using unportable primitives unless
> there is very good reason.  FWIW, I plan to make vtophys(),
> rman_get_virtual(), and other evil and i386-specific primitives very
> hard to use in 6-CURRENT, and I will strongly oppose importing new
> code that tries to abuse them.  I was just hoping that 5.3 would pass
> before people started testing the boundaries.

Note that while my reply was to Marcel who replied to Warner, my comment 
was meant to be informative, not suggest either of them are responsible 
for implementing the fix.

-- 
Nate