cvs commit: src/sbin/mount mntopts.h mount.8 mount.c src/sbin/mount_std mount_std.8

[Ruslan Ermilov]

On Tue, Nov 30, 2004 at 08:40:59PM +0100, Poul-Henning Kamp wrote:
> In message <20041130192316.GB3845 at ip.net.ua>, Ruslan Ermilov writes:
> 
> >> The reason I did not remove MNT_NODEV but only #defined it to zero was
> >> to make it silently ignored.
> >> 
> >To make it silently ignored, you should have left it with its old value.
> >Most operations with MNT_* constants are "bitwise AND", and so zero was
> >not a good choice.
> 
> I tried to find my copy of "Bitmaps for dummies" to check what
> you're saying but I can't find it right now, still, I'm very sure
> that you are wrong, I just don't have the book to prove it.
> 
> Most operations on MNT_* are "bitwise OR" and a zero is perfectly OK.
> 
Well, definitely *not* in sbin/mount/mount.c.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041130/991bae5e/attachment.bin