cvs commit: src/sys/dev/acpica acpi_pci_link.c

John Baldwin jhb at FreeBSD.org
Tue Nov 30 12:11:02 PST 2004


On Tuesday 30 November 2004 12:48 pm, Nate Lawson wrote:
> njl         2004-11-30 17:48:10 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/acpica       acpi_pci_link.c
>   Log:
>   Don't bother locking in attach().  At boot time, we're single-threaded
>   anyway and for some reason, witness seems confused about what's already
>   locked and triggers a false panic.

Witness doesn't get confused, there's some other bug.  I'm not sure that all 
device attachments are always single-threaded though.  Imagine hotplugging a 
docking station, that's going to add a new PCI bus.  It probably won't have 
an internal programming router (probably not physically possible), but I 
don't think we should assume for now that attach is only a boot-time 
scenario.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org


More information about the cvs-src mailing list