cvs commit: src/sys/dev/acpica acpi_pci_link.c acpi_pcib.c acpi_pcib_acpi.c acpi_pcib_pci.c acpi_pcibvar.h

[Nate Lawson]

Pawel Jakub Dawidek wrote:
> On Tue, Nov 23, 2004 at 10:26:44PM +0000, John Baldwin wrote:
> +> jhb         2004-11-23 22:26:44 UTC
> +> 
> +>   FreeBSD src repository
> +> 
> +>   Modified files:
> +>     sys/dev/acpica       acpi_pci_link.c acpi_pcib.c 
> +>                          acpi_pcib_acpi.c acpi_pcib_pci.c 
> +>                          acpi_pcibvar.h 
> +>   Log:
> +>   Rework the ACPI PCI link code.
> [...]
> 
> Is this related to:
> 
> FreeBSD 6.0-CURRENT #14: Tue Nov 30 18:17:51 CET 1999
>     root at slayer.hell.invalid:/usr/obj/usr/src/HEAD/src/sys/LCF
> Timecounter "i8254" frequency 1193182 Hz quality 0
> CPU: Intel(R) XEON(TM) CPU 1.80GHz (1799.76-MHz 686-class CPU)
>   Origin = "GenuineIntel"  Id = 0xf24  Stepping = 4
>   Features=0x3febfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CLFLUSH,DTS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM>
>   Hyperthreading: 2 logical CPUs
> real memory  = 1073741824 (1024 MB)
> avail memory = 1046126592 (997 MB)
> ACPI APIC Table: <INTEL          APIC  >
> FreeBSD/SMP: Multiprocessor System Detected: 4 CPUs
>  cpu0 (BSP): APIC ID:  0
>  cpu1 (AP): APIC ID:  1
>  cpu2 (AP): APIC ID:  6
>  cpu3 (AP): APIC ID:  7
> MADT: Forcing active-low polarity and level trigger for SCI
> ioapic0 <Version 1.1> irqs 0-15 on motherboard
> ioapic1 <Version 1.1> irqs 16-31 on motherboard
> npx0: [FAST]
> npx0: <math processor> on motherboard
> npx0: INT 16 interface
> acpi0: <INTEL   RSDT> on motherboard
> acpi0: Power Button (fixed)
> can't fetch resources for \_SB_.LN1_ - AE_AML_INVALID_RESOURCE_TYPE
> acpi_ec0: <Embedded Controller: GPE 0x35> port 0xca7,0xca6 on acpi0
> Timecounter "ACPI-safe" frequency 3579545 Hz quality 1000
> acpi_timer0: <32-bit timer at 3.579545MHz> port 0x508-0x50b on acpi0
> cpu0: <ACPI CPU> on acpi0
> cpu1: <ACPI CPU> on acpi0
> cpu2: <ACPI CPU> on acpi0
> cpu3: <ACPI CPU> on acpi0
> acpi_button0: <Sleep Button> on acpi0
> pci_link0: <ACPI PCI Link LN1_> on acpi0
> device_attach: pci_link0 attach returned 6
> pci_link1: <ACPI PCI Link LN10> irq 16 on acpi0
> panic: _sx_xlock (ACPI PCI link): xlock already held @ /usr/src/HEAD/src/sys/modules/acpi/acpi/../../../dev/acpica/acpi_pci_link.c:297
> cpuid = 0
> KDB: enter: panic
> [thread pid 0 tid 0 ]
> Stopped at      kdb_enter+0x2c: leave   
>

This is a fake panic I think.  In any case, there is no need to lock in 
attach since the the boot code is single-threaded.  I committed this change.

There is another error above for LN1_ that should be examined separately.

-Nate