cvs commit: src/sys/kern kern_exit.c kern_sig.c

Ken Smith kensmith at cse.Buffalo.EDU
Thu Mar 18 09:11:04 PST 2004


On Wed, Mar 17, 2004 at 04:14:44PM -0500, Brian F. Feldman wrote:
> John Baldwin <jhb at FreeBSD.org> wrote:
> > jhb         2004/03/05 14:39:53 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/kern             kern_exit.c kern_sig.c 
> >   Log:
> >   - Push down Giant in exit() and wait().
> >   - Push Giant down a bit in coredump() and call coredump() with the proc
> >     lock already held rather than unlocking it only to turn around and
> >     relock it.
> 
> Please review this to remove any places VFS is called into without Giant, 
> i.e. vrele(tracevp).
> 

It's possible the alpha ref machine is suffering from this the past
two days:

panic: mutex Giant not owned at ../../../kern/vfs_subr.c:899
at line 719 in file ../../../kern/kern_mutex.c
cpuid = 0;
Stack backtrace:
db_print_backtrace() at db_print_backtrace+0x18
backtrace() at backtrace+0x2c
__panic() at __panic+0x210
_mtx_assert() at _mtx_assert+0xec
vinvalbuf() at vinvalbuf+0x5c
vclean() at vclean+0xc4
vgonel() at vgonel+0x74
vgone() at vgone+0x4c
pfs_exit() at pfs_exit+0x80
exit1() at exit1+0x40c
sys_exit() at sys_exit+0x24
syscall() at syscall+0x37c
XentSys() at XentSys+0x64
--- syscall (1) ---
--- user mode ---
boot() called on cpu#0

-- 
						Ken Smith
- From there to here, from here to      |       kensmith at cse.buffalo.edu
  there, funny things are everywhere.   |
                      - Theodore Geisel |


More information about the cvs-src mailing list