cvs commit: src/sys/i386/include dvcfg.h physio_proc.h src/sys/amd64/include dvcfg.h physio_proc.h src/sys/compat/netbsd dvcfg.h physio_proc.h src/sys/dev/ct bshw_machdep.c ct.c ct_isa.c src/sys/dev/ncv ncr53c500.c ncr53c500_pccard.c ncr53c500hw.h ...

Peter Wemm peter at wemm.org
Mon Mar 15 07:42:18 PST 2004


On Monday 15 March 2004 05:48 am, Takahashi Yoshihiro wrote:
> In article <20040315.175959.11208797.imp at bsdimp.com>
>
> "M. Warner Losh" <imp at bsdimp.com> writes:
> > : sys/dev/<device_name>/ is best.  Right now dev/ only has
> > : directories, but I'm not sure what [pseudo] device these should
> > : go with.
> >
> > dev/ic already exists for this purpose.  Or at least one similar to
> > it.
>
> No.  dev/ic is for chip specific registers, not for common files
> between drivers.

Not to mention that these are stub files.. for example, physio_proc.h 
is:

struct physio_proc {
};
static __inline struct physio_proc *
physio_proc_enter(bp)
        struct buf *bp;
{
        return NULL;
}

static __inline void
physio_proc_leave(pp)
        struct physio_proc *pp;
{
}

dvcfg.h is 5 macros and a 2-item struct.

Anyway, I made the mistake of assuming that these were for NetBSD API 
compatability.  I initially thought that the dvcfg.h file was for 
interfacing with NetBSD's config(8) system.  But instead it seems they 
are for a variant of NetBSD.

I don't really care where they go, as long as it isn't in the MD include 
areas (they are not MD!), and not in sys/.  My favorites right now are
dev/pc98/* or compat/pc98/*.  I would also like sys/device_port.h to
move there too since it is used by the same group of ct/ncv/nsp/stg 
drivers.
-- 
Peter Wemm - peter at wemm.org; peter at FreeBSD.org; peter at yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5


More information about the cvs-src mailing list