cvs commit: src/lib/libpam/modules/pam_radius pam_radius.c

Alexander Kabaev kan at FreeBSD.org
Fri Jun 25 05:38:27 PDT 2004


On Fri, Jun 25, 2004 at 02:16:27PM +0200, Dag-Erling Sm?rgrav wrote:
> Ruslan Ermilov <ru at FreeBSD.org> writes:
> > On Fri, Jun 25, 2004 at 11:28:50AM +0200, Dag-Erling Sm?rgrav wrote:
> > > Alexander Kabaev <kan at FreeBSD.org> writes:
> > > >   Log:
> > > >   Remove the use of cast as lvalue.
> > > This trades one style bug for another (missing space before *), breaks
> > > the build on 64-bit platforms, and violates maintainership.
> > Ah, so this commit is responsible for a cross-build breakage...
> 
> No, this one currently only breaks Alpha because we apparently don't
> enforce alignment requirements on other platforms.
> 
It definitely worked for amd64 world, which I guess does not have such
strict alignment requirements. I backed out the change and will let 
maintainer to deal with it to his heart desire. Apologies for DES
for intruding on his turf.

I will downgrade WARNS level for this module at the time of GCC 3.4 import
if the warning will still be there by then.

--
Alexander Kabaev


More information about the cvs-src mailing list