cvs commit: src/share/mk bsd.kmod.mk

[Pawel Jakub Dawidek]

On Fri, Jun 18, 2004 at 07:47:33PM +0300, Ruslan Ermilov wrote:
+> On Fri, Jun 18, 2004 at 04:38:43PM +0000, Pawel Jakub Dawidek wrote:
+> > pjd         2004-06-18 16:38:43 UTC
+> > 
+> >   FreeBSD src repository
+> > 
+> >   Modified files:
+> >     share/mk             bsd.kmod.mk 
+> >   Log:
+> >   Check if ${_dir}/kern exists as well, because if it doesn't exists
+> >   we will fail later and we can miss good kernel source tree directory.
+> >   I found this trying to compile kld module and it finds 'conf/kmod.mk'
+> >   in '../..', but it fails later, because there is no 'kern' directory,
+> >   but there is valid kernel source tree still in /usr/src/sys/.
+> >   
+> >   Revision  Changes    Path
+> >   1.89      +2 -2      src/share/mk/bsd.kmod.mk
+> > 
+> It fixes just one out of dozen other possibilities of partial checkouts.

Yes, but there are two checks:

For (...)
If exists(${_dir}/conf/<something>)
	Ok.
EndIf
EndFor
If !exists(${_dir}/conf) || !exists(${_dir}/kern)
	Bad.
EndIf

So IMHO we should check two directories in both places or one directory
in both places, but not one here and two there.
Does it make sense to you?

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040620/79a2d64f/attachment.bin