cvs commit: src/sys/sys malloc.h src/sys/kern kern_malloc.csrc/sys/vm vm_contig.c vm_page.h

Scott Long scottl at
Mon Jul 19 00:17:08 PDT 2004

Alan Cox wrote:
> On Mon, Jul 19, 2004 at 01:00:27AM -0600, Scott Long wrote:
>>This is a pretty darn big change to something that is so vital to so 
>>many drivers (not including busdma, which means that this touches nearly
>>every driver).  Who reviewed this?  Was it discussed on a public mailing
>>list?  What kind of testing was done for it?  If you can't answer these
>>questions then I'm not terribly thrilled.
> I reviewed an earlier version of this and gave Brian some feedback.
> It is important to note that he added the new implementation side-by-side
> with the old. By default, the old implementation is still used.  So, I
> wouldn't be too concerned.
> Alan

Ok, I guess I missed the mention of the vm.old_contigmalloc tunable on
my first reading.  I'd still like to know what it has been tested on and
what the future testing and maintenance requirements are.  This work
looks to be very interesting and beneficial, so please don't take these
emails to mean that I don't like it.  I'm just a bit nervous these days.


More information about the cvs-src mailing list