[src] cvs commit: src/sys/dev/fdc fdc.c fdc_isa.c fdc_pccard.c fdcvar.h src/sys/modules/fdc Makefile

[Nate Lawson]

On Wed, 7 Jul 2004, Nate Lawson wrote:
> M. Warner Losh wrote:
> > I went the route of 'exposing' the softc, because that's how newbus
> > works: it manages the softc, and in order to manage the softc you have
> > to expose its size.  I treid to express that in the reviews, but I
> > guess that got lost in the shuffle.  Bruce doesn't like it, but we do
> > it all over the place and the world hasn't come to the end.  Anyway,
> > after the set of mail that was sent out, I thought that I was supposed
> > to commit the simple split, then you were going to specialize things
> > for acpi.  That's why I went ahead and committed this.  phk's recent
> > changes to fdc reminded me to merge this stuff....
>
> What about instead exposing the size through a extern const int and used
> that to set the softc size in the device initialization?  The internals
> of the softc aren't really needed.
>
> My code uses a softc size of zero and has a function in fdc.c that is
> called by bus attachments that allocates it and does a
> device_set_softc().  This mostly works.

Actually, I forgot to ask -- are you ok with me committing my code which
hides the softc and uses device_set_softc() privately within fdc.c to
manage it?  We'll still need fdcvar.h to hold function definitions.

-Nate