cvs commit: src/sys/vm uma_core.c

M. Warner Losh imp at
Sun Jul 4 10:10:59 PDT 2004

In message: <20040704162623.GB997 at>
            Brian Fundakowski Feldman <green at FreeBSD.ORG> writes:
: On Sun, Jul 04, 2004 at 04:14:13PM +0000, Bosko Milekic wrote:
: > 
: > This is unfair.  I told you both in public and in private that
: > I didn't think this approach of segragating this behavior to mbuf
: > allocations was the right approach and even suggested what the right
: > approach should have been.  You asked me to review a change that
: > further segragated this behavior to mbuf allocations but then
: > committed the change 5 minutes later without giving me an
: > opportunity to reply.
: > 
: > What I've done is made the sysctl-introduction change myself and
: > committed it instead of this.
: > 
: > In the future I hope that you'll learn to be more patient and less
: > righteous when ordering others not to commit something before
: > going through the SO.
: You pointed out that it was incorrect because any of the mbuf zones
: could be allocated from with locks held and you wanted to prevent
: that, so I made the change _I_ had done before less bogus.
: You just introduced a gaping security hole that is turned on by
: default.  Back this out immediately.


Yelling at other committers is viewed dimly by core.  If you don't
stop it, core will take action to correct the problem, despite pending
elections.  Proof by assertion isn't acceptible and your actions here
disturb me greatly.

It is the security officer's responsibiltiy to make such requests, not

I'm sorry to shout, but Brian, your hands are far from clean in this
debate.  Please learn how to work with your fellow committer rather
than stomp on them.  Thanks.


More information about the cvs-src mailing list