cvs commit: src/sys/ddb db_command.c

Bruce Evans bde at zeta.org.au
Sun Feb 29 23:07:11 PST 2004


On Sun, 29 Feb 2004, Nate Lawson wrote:

> On Sun, 29 Feb 2004, Poul-Henning Kamp wrote:
> >   FreeBSD src repository
> >
> >   Modified files:
> >     sys/ddb              db_command.c
> >   Log:
> >   Give DDB a "watchdog" command which disables all watchdogs.
> >
> >   Revision  Changes    Path
> >   1.53      +21 -0     src/sys/ddb/db_command.c
>
> Shouldn't that be hooked into the normal debugger enter sequence?

Perhaps.  It is completely misplaced in db_command.c either way.
Subsystem-specific ddb commands go in the subsystem files.  Other
bugs in it include:
- no ifdefs to make it go away when watchdogs are not configured.
- using an event handler without including <sys/eventhandler.h
These bugs would automatically not be there if it were in watchdog.c,
and I wouldn't see them because I don't use watchdogs.

Bruce


More information about the cvs-src mailing list