cvs commit: src/sys/vm vm_kern.c

Tony Finch dot at dotat.at
Mon Feb 16 10:59:43 PST 2004


On Mon, Feb 16, 2004 at 01:55:51PM -0500, Robert Watson wrote:
> On Mon, 16 Feb 2004, Dag-Erling Smorgrav wrote:
> > 
> >   Don't panic if we fail to satisfy an M_WAITOK request; return 0 instead.
> >   The calling code will either handle that gracefully or cause a page fault.
> 
> This substantially modifies the semantics of the two consumers of
> kmem_malloc(), and those semantic changes trickle up the stack to a number
> of important places.  Are you going to update the consumers (and their
> comments) as well?

ISTR that the whole point of M_WAITOK when it was introduced was that
callers could rely on the fact that it would not return NULL.

Tony.
-- 
f.a.n.finch  <dot at dotat.at>  http://dotat.at/
RATTRAY HEAD TO BERWICK ON TWEED: WEST 2 OR 3 INCREASING NORTHWEST 4 OR 5
LOCALLY 6 THEN DECREASING 3 LOCALLY 4 OR 5. PATCHY RAIN AT FIRST, THEN FINE
AND DRY. GENERALLY GOOD, BUT PERHAPS LOCALLY MODERATE IN RAIN. SLIGHT.


More information about the cvs-src mailing list