cvs commit: src/sys/kern tty.c

[Robert Watson]

rwatson     2004/02/03 21:46:05 PST

  FreeBSD src repository

  Modified files:
    sys/kern             tty.c 
  Log:
  A variety of further cleanups to ttyinfo():
  
  - Rename temporary variable names ("tmp", "tmp2") to more informative
    names ("load", "pctcpu", "rss", ...)
  
  - Unclutter indentation and return paths: rather than lots of nested
    ifs, simply return earlier if it's not going to work out.  Simplify
    general structure and avoid "deep" code.
  
  - Comment on the thread/process selection and locking.
  
  - Correct handling of "running"/"runnable" states, avoid "unknown"
    that people were seeing for running processes.  This was due to
    a misunderstanding of the more complex state machine / inhibitors
    behavior of KSE.
  
  - Do perform ttyinfo() printing on KSE (P_SA) processes, it seems
    generally to work.
  
  While I initially attempted to formulate this as two commits (one
  layout, the other content), I concluded that the layout changes were
  really structural changes.
  
  Many elements submitted by:  bde
  
  Revision  Changes    Path
  1.207     +85 -78    src/sys/kern/tty.c