cvs commit: src/sys/netinet ip_icmp.c

Bruce M Simpson bms at spc.org
Tue Feb 3 04:24:50 PST 2004


On Mon, Feb 02, 2004 at 04:06:22PM -0800, Brooks Davis wrote:
> I'm not sugguesting caching the ifp.  I'm suggesting storing the value
> of ifp->if_index.  You then use ifnet_byindex to get then the ifp when
> needed.  You have to check that it isn't NULL, but you should to be
> doing that for the ifunit() call as well since it will return NULL and
> cause a panic if the admin makes a typo.

Good catch. Thanks.

BMS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 167 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040203/91239fb1/attachment-0001.bin


More information about the cvs-src mailing list