cvs commit: src/share/examples/etc make.conf

[Ruslan Ermilov]

Hi Tom,

On Wed, Dec 15, 2004 at 09:58:48AM -0500, Tom Rhodes wrote:
> So, your saying that in revision 1.238 it was "ok" for you to
> "break existing style" without documenting it in the commit
> log:
> 
> "For variables that are only checked with defined(), don't provide
> any fake value."
> 
> But not ok for me to "break existing sytle" in revision 1.241
> which returned the style back to what we had for at least 2-3
> years?  (Note, my time of 2-3 years may be off, it's just a
> guess from since I've had my commit bit).
> 
My bad that I didn't put it into the commit log.  I even
remember thinking about splitting the style/change thing
between two commits, but then given up on the idea and
just went ahead and committed it in a single revision.
My excuse for that being: this commit covered a zillion
of other files (see commitlogs/share.20041201.gz).

> > see any controversy between these two revisions (rev. 1.211 and
> > the upcoming revision when you commit my patch ;), both use the
> > rule "don't break an existing style".
> 
> There is no real "controversy" over revisions.  I just don't
> particularly fancy being told to do something on one commit
> and then get told I did almost the same thing wrong in another
> commit.
> 
Sorry about that, but some facts just don't hold forever.  ;)

> I agree with you that variables for ppp(8) should be placed in
> their own specific area;
> 
Also because that "NO" area is for documenting knobs that affect
*not* building some parts of the world.  In case of ppp(8), the
knobs only tell how to *not* build parts of ppp(8).  If there
were NO_PPP, it would belong to this section indeed.

> however, the style thing I'm a bit
> leary on.  Also, please take note that if I'm coming off as an
> asshole, I don't mean to be.  I'm just concerned about how this
> may play out.
> 
OK, how about just committing my patch, now that you have all
explanations in hands.  Feel free to attribute your confusion
to me.


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041215/c0753f36/attachment.bin