cvs commit: src/sys/ufs/ffs ffs_vfsops.c

[Ruslan Ermilov]

On Mon, Dec 13, 2004 at 02:06:26PM +0100, Poul-Henning Kamp wrote:
> In message <20041213113310.GB51149 at ip.net.ua>, Ruslan Ermilov writes:
> 
> >Another issue:
> >
> >- boot without a diskette in the drive
> >- insert a diskette #1 into the drive
> >- newfs_msdos it
> >- mount_msdosfs it
> >- copy some files onto it
> >- unmount it
> >- insert another (possibly unformatted) diskette #2
> >- mount_msdosfs it and find it somehow succeeds
> >- list the contents of the diskette and find that it's identical
> >  to the contents of diskette #1, including MD5 checksums of
> >  all files
> >
> >This smells like a bufcache issue, but I may be wrong about it.
> 
> Sounds like the same thing.
> 
> Can you try this:
> 
> ==== //depot/user/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c#45 - /bang/p4/phk/phk_bufwork/sys/fs/msdosfs/msdosfs_vfsops.c ====
> @@ -719,6 +719,7 @@
>  error_exit:
>         if (bp)
>                 brelse(bp);
> +       vinvalbuf(devvp, V_SAVE, NOCRED, td, 0, 0);
>         if (cp != NULL) {
>                 DROP_GIANT();
>                 g_topology_lock();
> 
Doesn't help.  Boot with an MS-DOS formatted floppy, mount
and unmount it, then:

Script started on Mon Dec 13 21:15:42 2004
hammer#	dd if=/dev/fd0 |hd
00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
*
2880+0 records in
2880+0 records out
1474560 bytes transferred in 47.905143 secs (30781 bytes/sec)
00168000
hammer#	mount_msdosfs /dev/fd0 /mnt
hammer#	ll /mnt
total 0
-rwxr-xr-x  1 root  wheel  0 Dec 13 21:02 foo
hammer#	umount /mnt

Script done on Mon Dec 13 21:17:08 2004


Cheers,
-- 
Ruslan Ermilov
ru at FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20041213/efeac2e0/attachment.bin