cvs commit: src/sys/geom/concat g_concat.c src/sys/geom/label g_label.c src/sys/geom/mirror g_mirror.c src/sys/geom/raid3 g_raid3.c src/sys/geom/stripe g_stripe.c

Pawel Jakub Dawidek pjd at FreeBSD.org
Thu Aug 26 06:10:32 PDT 2004


On Thu, Aug 26, 2004 at 02:56:12PM +0200, Poul-Henning Kamp wrote:
+> In message <200408261242.i7QCgl7m012027 at repoman.freebsd.org>, Pawel Jakub Dawid
+> ek writes:
+> 
+> >  Log:
+> >  Skip providers with not defined sector size.
+> 
+> This is wrong.  A provider with a non-zero access count should always
+> have a sector size.  The sectorsize can not be trusted if the access
+> counts are zero.

Yes, I know that it should be done this way, but I'm not going to fix
atapi-cd.c, scsi_da.c and scsi_cd.c and who knows what else.
Those classes set error to 0 even when provider has not sectorsize
and mediasize defined.

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040826/c20d31c6/attachment.bin


More information about the cvs-src mailing list