cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ...

[Brian Fundakowski Feldman]

On Mon, Aug 16, 2004 at 09:51:12AM -0400, John Baldwin wrote:
> On Monday 16 August 2004 01:43 am, Brian Fundakowski Feldman wrote:
> > On Sun, Aug 15, 2004 at 10:20:55PM -0700, John-Mark Gurney wrote:
> > > Brian Fundakowski Feldman wrote this message on Sun, Aug 15, 2004 at 22:38 
> -0400:
> > > > On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote:
> > > > > sure, I'd like a quick peak at the patch though (if it takes me more
> > > > > than a day, go ahead and commit).
> > > >
> > > > I'd very much like you to look it over.  I haven't tested it, just made
> > > > the stylistic changes.  If it were more complete (i.e. satisfy bde),
> > > > every spurious blank line (that is, all of them inside functions which
> > > > are not between variable declarations and code) would be gone, too, but
> > > > that can be kind of harsh.
> > >
> > > As was pointed out...  blank lines at the top of functions w/o variables
> > > are mandated by style(9)...
> >
> > The manpage is either wrong or misleading, so either way, I'm waiting
> > to hear from bde.
> 
> I've never been confused on that topic Brian.  Just accept it and move on.

Whatever the case, I really don't care -- I would still like clarification
so that style(9) can be fixed.  The only style issue that I'm very
concerned about here is the flag/bitmask one, but there's really nothing
I can do.  Nothing against jmg or grog or dillon personally, but it's
helpful to most of the rest of the developers that code look similar,
at the expense of -- what all of us end up doing -- giving up personal
preferences.

If it ain't gonna happen, fine, but one thing FreeBSD is supposed to
have (BSD, actually) is as much internal consistency as we can
reasonably manage.  It's a nice change from, say, Linux.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green at FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\