cvs commit: src/sys/cam/scsi scsi_target.c src/sys/dev/mii mii.c src/sys/fs/fifofs fifo_vnops.c src/sys/gnu/ext2fs ext2_vnops.c src/sys/kern init_main.c kern_conf.c kern_descrip.c kern_event.c kern_exec.c kern_exit.c kern_fork.c kern_sig.c sys_pipe.c tty.c ...

[Garance A Drosihn]

At 10:38 PM -0400 8/15/04, Brian Fundakowski Feldman wrote:
>On Sun, Aug 15, 2004 at 06:51:08PM -0700, John-Mark Gurney wrote:
>  >
>  > sure, I'd like a quick peak at the patch though (if it takes me
>  > more than a day, go ahead and commit).
>
>I'd very much like you to look it over.  I haven't tested it, just
>made the stylistic changes.  If it were more complete (i.e. satisfy
>bde), every spurious blank line (that is, all of them inside functions
>which are not between variable declarations and code) would be gone,
>too, but that can be kind of harsh.
>
>--- /usr/src/sys/kern/kern_event.c	Sun Aug 15 15:44:41 2004
>+++ kern_event.c	Sun Aug 15 22:36:25 2004

>@@ -232,7 +231,6 @@
>  static int
>  filt_fileattach(struct knote *kn)
>  {
>-
>  	return (fo_kqfilter(kn->kn_fp, kn));
>  }
>

In some cases, such as this one, you are removing a blank line
which style(9) wants to have there.  ISTR being told that if there
are no local variables in a routine, there should be a blank line
before the first executable statement.  Looking at the man page, I
think that is shown by the example:

static void
usage()
{
	/* Insert an empty line if the function has no local variables. */


-- 
Garance Alistair Drosehn            =   gad at gilead.netel.rpi.edu
Senior Systems Programmer           or  gad at freebsd.org
Rensselaer Polytechnic Institute    or  drosih at rpi.edu