cvs commit: src/bin/dd args.c

Pawel Jakub Dawidek pjd at FreeBSD.org
Mon Aug 2 00:02:16 PDT 2004


On Sun, Aug 01, 2004 at 05:03:38PM -0700, Nate Lawson wrote:
+> >@@ -361,18 +361,23 @@
+> > 
+> > 	mult = 0;
+> > 	switch (*expr) {
+> >+	case 'B':
+> > 	case 'b':
+> > 		mult = 512;
+> > 		break;
+> 
+> Instead of doubling the case statements, it's simpler to do
+> "switch (tolower(*expr))" or toupper().

Sure, but I leave it to maintainer to decide.
I personally prefer to see exactly what's going on, and I also wasn't
sure while committing if we really want capital 'W'.

-- 
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd at FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20040802/549468f4/attachment.bin


More information about the cvs-src mailing list